Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools): log[level] compatible with when first argument is undefined (fix #1555) #1565

Merged
merged 1 commit into from Sep 27, 2022

Conversation

sun0day
Copy link
Contributor

@sun0day sun0day commented Sep 24, 2022

fix #1555

unit test added

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sun0day
Copy link
Contributor Author

sun0day commented Sep 26, 2022

It is weird fail in node 14&18 in ubuntu. :(

@mcollina mcollina merged commit e6d355c into pinojs:master Sep 27, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msg property is not logged when first arg is undefined
2 participants