Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Update to named parameters #1583

Closed
wants to merge 2 commits into from

Conversation

debadutta98
Copy link

This PR Closes #1577

Update simple parameters to named parameters of LevelChangeEventListener so the users can easily identify the type of parameter

Work

  • Update pino.d.ts
  • Update doc/api.md

Thank you!

@debadutta98 debadutta98 changed the title [Enhancement] Update the named parameters [Enhancement] Update to named parameters Nov 3, 2022
@jsumners
Copy link
Member

jsumners commented Nov 3, 2022

That issue still needs discussion. We don't want to do this one method at a time. It would be a major change.

Copy link

github-actions bot commented Nov 4, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to named parameters
2 participants