Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add 'best performance for basic stdout logging' to help.md #1584

Merged
merged 4 commits into from May 8, 2023

Conversation

janeklb
Copy link
Contributor

@janeklb janeklb commented Nov 6, 2022

My attempt to capture @mcollina's reply: #1491 (comment) in some doc form

docs/help.md Outdated
<a id="best-performance-for-stdout"></a>
## Best performance for logging to `stdout`

The best performance for logging directly to stdout is achieved by using the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The best performance for logging directly to stdout is achieved by using the
The best performance for logging directly to stdout is _usually_ achieved by using the

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcollina just for the sake of curiosity could you elaborate on when the default configuration would not yield the best performance for logging directly to stdout?

docs/help.md Outdated Show resolved Hide resolved
janeklb and others added 2 commits November 8, 2022 12:02
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit b473f36 into pinojs:master May 8, 2023
@janeklb janeklb deleted the patch-1 branch May 8, 2023 12:30
Copy link

github-actions bot commented May 8, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants