fix msg precendence when sending a merging object with msg and err #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
approved these changes
Feb 22, 2023
joelmukuthu
reviewed
Jul 21, 2023
| @@ -193,7 +193,7 @@ function write (_obj, msg, num) { | |||
| } | |||
| } else { | |||
| obj = _obj | |||
| if (msg === undefined && _obj[errorKey]) { | |||
| if (msg === undefined && _obj.msg === undefined && _obj[errorKey]) { | |||
There was a problem hiding this comment.
Hi all, should this be _obj[messageKey] (instead of _obj.msg) since that msg key is configurable?
There was a problem hiding this comment.
@joelmukuthu I think that may be true. Can you write a test that proves it and submit a PR to fix?
There was a problem hiding this comment.
Done: #1746. I did two separate git pushes to try and trigger the failing test on CI but it didn't work as approval is needed. Hopefully you'll be able to trigger CI on the first commit!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1650