Remove (package.json).files

[jsumners]

This addresses what was left unfinished from #1588 and hopefully makes it clear we want the files in the package (re: #1672).

[koresar]

I'm afraid removing this much would result in test folder still be published.

Instead, we should remove the single line from this file - the "test" array element.

[jsumners]

I'm afraid removing this much would result in test folder still be published.

Yes. That is correct.

[koresar]

Any explanation why people want /test/ files uploaded to npm (and then to millions of computers world wide) ?

[jsumners]

So that they can be referenced when navigating a project's source tree.

[koresar]

After git checkout anyone can navigate the source tree.

Why do we upload the "test" fodler to NPM?
https://www.npmjs.com/package/pino?activeTab=code

[kibertoad]

I don't see any benefits in this change.

[koresar]

@kibertoad would you see benefits in removing the "test" folder (only!) from the npm tarball?

[kibertoad]

@koresar I do, but I think I'm in the minority in the pino team. There was this discussion before, and broadly pino (and fastify) teams consider tests to be part of project documentation, and prefer it bundled for easy perusal by consumers of the libraries.

[koresar]

Oh my god.

Degrading the DX of millions to improve the DX of a few.

How about giving a link in Readme:

Here are our unit tests, find examples there: <link>

[jsumners]

First, how are these a degradation of your experience? Second, a link in a readme isn't going to work when an internet connection is not available or is very unreliable.

[Fdawgs]

@koresar I do, but I think I'm in the minority in the pino team. There was this discussion before, and broadly pino (and fastify) teams consider tests to be part of project documentation, and prefer it bundled for easy perusal by consumers of the libraries.

See fastify/skeleton#42

Not a fan of unnecessary files being added either from both an environmental and security perspective, but understand it makes the packages easier to maintain by not having to dance with .npmignore and package.json files

[mcollina]

lgtm

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.