Docs: add favicon #1698
Merged
Docs: add favicon #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated with realfavicongenerator.net
Code generated from realfavicongenerator.net
This isn't a PWA, so doesn't make sense to have a manifest right?
See last commit, don't think it's necessary.
So it works with GitHub pages
I don't really have a way to test these so I'll stick to the basics
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like to set up a browser window for just my docs, all in pinned tabs on Chrome (i.e. just the icon showing). Since Pino didn't have one yet, I decided to see if I couldn't set one up myself.
Referencing the existing pino-tree.png is possible, but because the image isn't square, it looked squashed. I headed over to realfavicongenerator.net and put pino-tree.png through it to get some more standardized favicons.
These 3 files were generated (along with a lot of other special-case ones that I removed since I couldn't easily test them). The website also provided some code to add in, which only needed one tweak--the removal of a
/before eachhref--to make GitHub pages support it.How do they look? (For smaller icon sizes, there's also the option of using bilinear or some other scaling technique, which looks more pixelated. I went with the default, just because it was the default.)