Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose errWithCause to browser API & add Node v20 #1701

Merged
merged 1 commit into from May 2, 2023
Merged

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented May 2, 2023

Fixes #1690

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina requested a review from jsumners May 2, 2023 11:05
@mcollina mcollina changed the title Expose errWithCause to browser API Expose errWithCause to browser API & add Node v20 May 2, 2023
@Fdawgs
Copy link
Member

Fdawgs commented May 2, 2023

Worth dropping Node 19 from the CI as well?

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why #1691 won't pass tests and this one will, but 🤷‍♂️.

Looks good to me.

@mcollina mcollina merged commit c0e11b9 into master May 2, 2023
18 of 19 checks passed
@mcollina mcollina deleted the fix-1690 branch May 2, 2023 11:45
Copy link

github-actions bot commented May 2, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exposes faux stdSerializers test fail on node v19.9.0
3 participants