Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default levels to opts in multistream #1760

Merged
merged 4 commits into from Aug 4, 2023
Merged

Add default levels to opts in multistream #1760

merged 4 commits into from Aug 4, 2023

Conversation

tzviki
Copy link
Contributor

@tzviki tzviki commented Jul 30, 2023 •
edited

closes #1677

@tzviki tzviki mentioned this pull request Jul 30, 2023
Closed
mcollina
mcollina requested changes Jul 31, 2023
View reviewed changes
lib/multistream.js Show resolved Hide resolved
@tzviki tzviki requested a review from mcollina July 31, 2023 16:14
mcollina
mcollina approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from jsumners August 1, 2023 08:28
jsumners
jsumners approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mcollina
Copy link
Member

mcollina commented Aug 2, 2023

the tests seems to be failing

@tzviki
Copy link
Contributor Author

tzviki commented Aug 2, 2023

I merged in master. Still trying to determine cause of failing tests, but cannot get to the bottom of it yet. Will keep looking

@tzviki
Copy link
Contributor Author

tzviki commented Aug 3, 2023

I'm confused as to why the tests are failing. This might not be too helpful, but trying this on my fork here it fails even without any changes (i.e. a simple pr with a comment added).
The tests pass when I simply try to re-run just the failed tests (sometimes after an attempt or 2).
I have better results when adding a small change to the failing test see here, but those are still not succeeding on first run (see here).
Happy to continue looking.

@jsumners
Copy link
Member

jsumners commented Aug 3, 2023 •
edited

I see this flake all the time and have no idea how to solve it.

https://github.com/pinojs/pino/actions/runs/5744929664/job/15586912900?pr=1760#step:5:24

mcollina
mcollina approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 459404f into pinojs:master Aug 4, 2023
17 of 18 checks passed
renovate bot added a commit to fwouts/previewjs that referenced this pull request Aug 4, 2023
@renovate
chore(deps): update dependency pino to ^8.15.0 (#1892)
c5e699e 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino](https://getpino.io)
([source](https://togithub.com/pinojs/pino)) | [`^8.14.2` ->
`^8.15.0`](https://renovatebot.com/diffs/npm/pino/8.14.2/8.15.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.14.2/8.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.14.2/8.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino (pino)</summary>

### [`v8.15.0`](https://togithub.com/pinojs/pino/releases/tag/v8.15.0)

[Compare
Source](https://togithub.com/pinojs/pino/compare/v8.14.2...v8.15.0)

#### What's Changed

- docs(transports): add axiom
[#&#8203;1753](https://togithub.com/pinojs/pino/issues/1753) by
[@&#8203;qlaffont](https://togithub.com/qlaffont) in
[pinojs/pino#1754
- Add pino-opentelemetry-transport as a known plugin to transports.md by
[@&#8203;Vunovati](https://togithub.com/Vunovati) in
[pinojs/pino#1757
- fix: example code in transports.md by
[@&#8203;exKAZUu](https://togithub.com/exKAZUu) in
[pinojs/pino#1761
- Add default levels to opts in multistream by
[@&#8203;tzviki](https://togithub.com/tzviki) in
[pinojs/pino#1760

#### New Contributors

- [@&#8203;qlaffont](https://togithub.com/qlaffont) made their first
contribution in
[pinojs/pino#1754
- [@&#8203;Vunovati](https://togithub.com/Vunovati) made their first
contribution in
[pinojs/pino#1757
- [@&#8203;exKAZUu](https://togithub.com/exKAZUu) made their first
contribution in
[pinojs/pino#1761
- [@&#8203;tzviki](https://togithub.com/tzviki) made their first
contribution in
[pinojs/pino#1760

**Full Changelog**:
pinojs/pino@v8.14.2...v8.15.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/fwouts/previewjs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to specfy/specfy that referenced this pull request Aug 4, 2023
@renovate
Update dependency pino to v8.15.0 (#91)
3340278 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino](https://getpino.io)
([source](https://togithub.com/pinojs/pino)) | [`8.11.0` ->
`8.15.0`](https://renovatebot.com/diffs/npm/pino/8.11.0/8.15.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.11.0/8.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.11.0/8.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino (pino)</summary>

### [`v8.15.0`](https://togithub.com/pinojs/pino/releases/tag/v8.15.0)

[Compare
Source](https://togithub.com/pinojs/pino/compare/v8.14.2...v8.15.0)

#### What's Changed

- docs(transports): add axiom
[#&#8203;1753](https://togithub.com/pinojs/pino/issues/1753) by
[@&#8203;qlaffont](https://togithub.com/qlaffont) in
[pinojs/pino#1754
- Add pino-opentelemetry-transport as a known plugin to transports.md by
[@&#8203;Vunovati](https://togithub.com/Vunovati) in
[pinojs/pino#1757
- fix: example code in transports.md by
[@&#8203;exKAZUu](https://togithub.com/exKAZUu) in
[pinojs/pino#1761
- Add default levels to opts in multistream by
[@&#8203;tzviki](https://togithub.com/tzviki) in
[pinojs/pino#1760

#### New Contributors

- [@&#8203;qlaffont](https://togithub.com/qlaffont) made their first
contribution in
[pinojs/pino#1754
- [@&#8203;Vunovati](https://togithub.com/Vunovati) made their first
contribution in
[pinojs/pino#1757
- [@&#8203;exKAZUu](https://togithub.com/exKAZUu) made their first
contribution in
[pinojs/pino#1761
- [@&#8203;tzviki](https://togithub.com/tzviki) made their first
contribution in
[pinojs/pino#1760

**Full Changelog**:
pinojs/pino@v8.14.2...v8.15.0

### [`v8.14.2`](https://togithub.com/pinojs/pino/releases/tag/v8.14.2)

[Compare
Source](https://togithub.com/pinojs/pino/compare/v8.14.1...v8.14.2)

#### What's Changed

- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 18.16.14 to
20.2.3 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino#1718
- build(deps-dev): bump rimraf from 4.4.1 to 5.0.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino#1719
- build(deps-dev): bump pino-pretty from 9.4.0 to 10.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino#1670
- docs: add pino-slack-webhook to list of v7+ compatible transports by
[@&#8203;youngkiu](https://togithub.com/youngkiu) in
[pinojs/pino#1730
- Add missing closing curly brace in transports documentation by
[@&#8203;JasoonS](https://togithub.com/JasoonS) in
[pinojs/pino#1737
- Issue [#&#8203;1735](https://togithub.com/pinojs/pino/issues/1735) -
Programmatic Integration as a transport fails by
[@&#8203;altearius](https://togithub.com/altearius) in
[pinojs/pino#1739
- build(deps-dev): bump typescript from 4.9.5 to 5.1.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino#1728
- build(deps-dev): bump bole from 4.0.1 to 5.0.5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino#1734
- build(deps-dev): bump eslint-plugin-n from 15.7.0 to 16.0.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino#1740
- fix: browser respect child logger log level by
[@&#8203;NicoVogel](https://togithub.com/NicoVogel) in
[pinojs/pino#1725
- Fix dependency version by
[@&#8203;jsumners](https://togithub.com/jsumners) in
[pinojs/pino#1747
- fix: use `messageKey` when giving message precedence over error by
[@&#8203;joelmukuthu](https://togithub.com/joelmukuthu) in
[pinojs/pino#1746

#### New Contributors

- [@&#8203;youngkiu](https://togithub.com/youngkiu) made their first
contribution in
[pinojs/pino#1730
- [@&#8203;JasoonS](https://togithub.com/JasoonS) made their first
contribution in
[pinojs/pino#1737
- [@&#8203;altearius](https://togithub.com/altearius) made their first
contribution in
[pinojs/pino#1739
- [@&#8203;NicoVogel](https://togithub.com/NicoVogel) made their first
contribution in
[pinojs/pino#1725
- [@&#8203;joelmukuthu](https://togithub.com/joelmukuthu) made their
first contribution in
[pinojs/pino#1746

**Full Changelog**:
pinojs/pino@v8.14.1...v8.14.2

###
[`v8.14.1`](https://togithub.com/pinojs/pino/compare/v8.14.0...v8.14.1)

[Compare
Source](https://togithub.com/pinojs/pino/compare/v8.14.0...v8.14.1)

###
[`v8.14.0`](https://togithub.com/pinojs/pino/compare/c1c8eb41240c0ae9282bac1741ae2ee7bdb82895...v8.14.0)

[Compare
Source](https://togithub.com/pinojs/pino/compare/c1c8eb41240c0ae9282bac1741ae2ee7bdb82895...v8.14.0)

###
[`v8.12.1`](https://togithub.com/pinojs/pino/compare/v8.12.0...c1c8eb41240c0ae9282bac1741ae2ee7bdb82895)

[Compare
Source](https://togithub.com/pinojs/pino/compare/v8.12.0...c1c8eb41240c0ae9282bac1741ae2ee7bdb82895)

###
[`v8.12.0`](https://togithub.com/pinojs/pino/compare/v8.11.0...v8.12.0)

[Compare
Source](https://togithub.com/pinojs/pino/compare/v8.11.0...v8.12.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm on friday,before 9am on
monday,every weekend" in timezone Europe/Paris, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/specfy/specfy).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to redwoodjs/redwood that referenced this pull request Aug 9, 2023
@renovate
fix(deps): update dependency pino to v8.15.0 (#9023)
0e25224 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino](https://getpino.io)
([source](https://togithub.com/pinojs/pino)) | [`8.14.1` ->
`8.15.0`](https://renovatebot.com/diffs/npm/pino/8.14.1/8.15.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.14.1/8.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.14.1/8.15.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino (pino)</summary>

### [`v8.15.0`](https://togithub.com/pinojs/pino/releases/tag/v8.15.0)

[Compare
Source](https://togithub.com/pinojs/pino/compare/v8.14.2...v8.15.0)

#### What's Changed

- docs(transports): add axiom
[#&#8203;1753](https://togithub.com/pinojs/pino/issues/1753) by
[@&#8203;qlaffont](https://togithub.com/qlaffont) in
[pinojs/pino#1754
- Add pino-opentelemetry-transport as a known plugin to transports.md by
[@&#8203;Vunovati](https://togithub.com/Vunovati) in
[pinojs/pino#1757
- fix: example code in transports.md by
[@&#8203;exKAZUu](https://togithub.com/exKAZUu) in
[pinojs/pino#1761
- Add default levels to opts in multistream by
[@&#8203;tzviki](https://togithub.com/tzviki) in
[pinojs/pino#1760

#### New Contributors

- [@&#8203;qlaffont](https://togithub.com/qlaffont) made their first
contribution in
[pinojs/pino#1754
- [@&#8203;Vunovati](https://togithub.com/Vunovati) made their first
contribution in
[pinojs/pino#1757
- [@&#8203;exKAZUu](https://togithub.com/exKAZUu) made their first
contribution in
[pinojs/pino#1761
- [@&#8203;tzviki](https://togithub.com/tzviki) made their first
contribution in
[pinojs/pino#1760

**Full Changelog**:
pinojs/pino@v8.14.2...v8.15.0

###
[`v8.14.2`](https://togithub.com/pinojs/pino/compare/v8.14.1...v8.14.2)

[Compare
Source](https://togithub.com/pinojs/pino/compare/v8.14.1...v8.14.2)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@wallactp wallactp mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

customLevels brake logging with transports
3 participants
@tzviki @mcollina @jsumners