Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding asString to the key #1779

Merged
merged 1 commit into from Aug 10, 2023
Merged

adding asString to the key #1779

merged 1 commit into from Aug 10, 2023

Conversation

tzviki
Copy link
Contributor

@tzviki tzviki commented Aug 8, 2023

This fixes issue-1767. It can maybe be added as a feature? not sure, but happy to discuss further
closes #1767

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will slow us down a bit but I don't think we can help it.

@mcollina mcollina merged commit da75c01 into pinojs:master Aug 10, 2023
17 of 18 checks passed
renovate bot added a commit to fwouts/previewjs that referenced this pull request Sep 8, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino](https://getpino.io)
([source](https://togithub.com/pinojs/pino)) | [`^8.15.0` ->
`^8.15.1`](https://renovatebot.com/diffs/npm/pino/8.15.0/8.15.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.15.0/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.15.0/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino (pino)</summary>

### [`v8.15.1`](https://togithub.com/pinojs/pino/releases/tag/v8.15.1)

[Compare
Source](https://togithub.com/pinojs/pino/compare/v8.15.0...v8.15.1)

#### What's Changed

- fix: replace nullish coalescing operator by
[@&#8203;hchangjae](https://togithub.com/hchangjae) in
[pinojs/pino#1780
- adding asString to the key by
[@&#8203;tzviki](https://togithub.com/tzviki) in
[pinojs/pino#1779
- feat([#&#8203;1595](https://togithub.com/pinojs/pino/issues/1595)):
improve stream entry type by [@&#8203;Puppo](https://togithub.com/Puppo)
in
[pinojs/pino#1778
- build(deps): bump pino-abstract-transport from v1.0.0 to 1.1.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino#1797
- Skip writing a big file test in CI and CITGM by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[pinojs/pino#1800

#### New Contributors

- [@&#8203;hchangjae](https://togithub.com/hchangjae) made their first
contribution in
[pinojs/pino#1780
- [@&#8203;Puppo](https://togithub.com/Puppo) made their first
contribution in
[pinojs/pino#1778

**Full Changelog**:
pinojs/pino@v8.15.0...v8.15.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/fwouts/previewjs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
thedavidprice added a commit to redwoodjs/redwood that referenced this pull request Sep 10, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino](https://getpino.io)
([source](https://togithub.com/pinojs/pino)) | [`8.15.0` ->
`8.15.1`](https://renovatebot.com/diffs/npm/pino/8.15.0/8.15.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.15.0/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.15.0/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino (pino)</summary>

### [`v8.15.1`](https://togithub.com/pinojs/pino/releases/tag/v8.15.1)

[Compare
Source](https://togithub.com/pinojs/pino/compare/v8.15.0...v8.15.1)

#### What's Changed

- fix: replace nullish coalescing operator by
[@&#8203;hchangjae](https://togithub.com/hchangjae) in
[pinojs/pino#1780
- adding asString to the key by
[@&#8203;tzviki](https://togithub.com/tzviki) in
[pinojs/pino#1779
- feat([#&#8203;1595](https://togithub.com/pinojs/pino/issues/1595)):
improve stream entry type by [@&#8203;Puppo](https://togithub.com/Puppo)
in
[pinojs/pino#1778
- build(deps): bump pino-abstract-transport from v1.0.0 to 1.1.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino#1797
- Skip writing a big file test in CI and CITGM by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[pinojs/pino#1800

#### New Contributors

- [@&#8203;hchangjae](https://togithub.com/hchangjae) made their first
contribution in
[pinojs/pino#1780
- [@&#8203;Puppo](https://togithub.com/Puppo) made their first
contribution in
[pinojs/pino#1778

**Full Changelog**:
pinojs/pino@v8.15.0...v8.15.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: David Price <thedavid@thedavidprice.com>
jtoar pushed a commit to redwoodjs/redwood that referenced this pull request Sep 13, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino](https://getpino.io)
([source](https://togithub.com/pinojs/pino)) | [`8.15.0` ->
`8.15.1`](https://renovatebot.com/diffs/npm/pino/8.15.0/8.15.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.15.0/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.15.0/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino (pino)</summary>

### [`v8.15.1`](https://togithub.com/pinojs/pino/releases/tag/v8.15.1)

[Compare
Source](https://togithub.com/pinojs/pino/compare/v8.15.0...v8.15.1)

#### What's Changed

- fix: replace nullish coalescing operator by
[@&#8203;hchangjae](https://togithub.com/hchangjae) in
[pinojs/pino#1780
- adding asString to the key by
[@&#8203;tzviki](https://togithub.com/tzviki) in
[pinojs/pino#1779
- feat([#&#8203;1595](https://togithub.com/pinojs/pino/issues/1595)):
improve stream entry type by [@&#8203;Puppo](https://togithub.com/Puppo)
in
[pinojs/pino#1778
- build(deps): bump pino-abstract-transport from v1.0.0 to 1.1.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino#1797
- Skip writing a big file test in CI and CITGM by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[pinojs/pino#1800

#### New Contributors

- [@&#8203;hchangjae](https://togithub.com/hchangjae) made their first
contribution in
[pinojs/pino#1780
- [@&#8203;Puppo](https://togithub.com/Puppo) made their first
contribution in
[pinojs/pino#1778

**Full Changelog**:
pinojs/pino@v8.15.0...v8.15.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: David Price <thedavid@thedavidprice.com>
bodinsamuel pushed a commit to specfy/specfy that referenced this pull request Sep 16, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino](https://getpino.io)
([source](https://togithub.com/pinojs/pino)) | [`8.15.0` ->
`8.15.1`](https://renovatebot.com/diffs/npm/pino/8.15.0/8.15.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.15.0/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.15.0/8.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino (pino)</summary>

### [`v8.15.1`](https://togithub.com/pinojs/pino/releases/tag/v8.15.1)

[Compare
Source](https://togithub.com/pinojs/pino/compare/v8.15.0...v8.15.1)

#### What's Changed

- fix: replace nullish coalescing operator by
[@&#8203;hchangjae](https://togithub.com/hchangjae) in
[pinojs/pino#1780
- adding asString to the key by
[@&#8203;tzviki](https://togithub.com/tzviki) in
[pinojs/pino#1779
- feat([#&#8203;1595](https://togithub.com/pinojs/pino/issues/1595)):
improve stream entry type by [@&#8203;Puppo](https://togithub.com/Puppo)
in
[pinojs/pino#1778
- build(deps): bump pino-abstract-transport from v1.0.0 to 1.1.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[pinojs/pino#1797
- Skip writing a big file test in CI and CITGM by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[pinojs/pino#1800

#### New Contributors

- [@&#8203;hchangjae](https://togithub.com/hchangjae) made their first
contribution in
[pinojs/pino#1780
- [@&#8203;Puppo](https://togithub.com/Puppo) made their first
contribution in
[pinojs/pino#1778

**Full Changelog**:
pinojs/pino@v8.15.0...v8.15.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday" in timezone
Europe/Paris, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/specfy/specfy).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asJson() method doesn't return a valid JSON if mergingObject key contains a double quote
3 participants