Support unknown, reverts 1783, add tests #1866

mcollina · 2023-12-14T09:18:49Z

This reverts #1783.
I as not aware that TypeScript matched errors as unknown.

Specifically, the following should be supported without any additional helpers:

try {
  dangerousFunc();
} catch (err) {
  logger.error(err)
}

As this is part of the Pino and should be supported on both JavaScript and TypeScript.

Fixes #1865

cc @Zamiell @kibertoad

This reverts commit 7f739d3.

Signed-off-by: Matteo Collina <hello@matteocollina.com>

mcollina · 2023-12-14T09:21:02Z

I've also added a couple of tests.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.16.2` -> `8.17.1`](https://renovatebot.com/diffs/npm/pino/8.16.2/8.17.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.17.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.17.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.16.2/8.17.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.16.2/8.17.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.17.1`](https://togithub.com/pinojs/pino/releases/tag/v8.17.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.0...v8.17.1) #### What's Changed - Support unknown, reverts 1783, add tests by [@mcollina](https://togithub.com/mcollina) in [pinojs/pino#1866 - Add Type Example for custom logger by [@mcollina](https://togithub.com/mcollina) in [pinojs/pino#1867 **Full Changelog**: pinojs/pino@v8.17.0...v8.17.1 ### [`v8.17.0`](https://togithub.com/pinojs/pino/releases/tag/v8.17.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.16.2...v8.17.0) #### What's Changed - build(deps): bump actions/github-script from 6 to 7 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1857 - Make license detectable by GitHub by [@10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [pinojs/pino#1859 - docs: Clarify how to log both to a custom transport and to stdout by [@kibertoad](https://togithub.com/kibertoad) in [pinojs/pino#1860 - Fix/types by [@UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [pinojs/pino#1858 - Bumped tsd to v0.29.0 by [@mcollina](https://togithub.com/mcollina) in [pinojs/pino#1863 - fix: typescript types by [@Zamiell](https://togithub.com/Zamiell) in [pinojs/pino#1783 - build(deps): bump pnpm/action-setup from 2.2.4 to 2.4.0 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1766 #### New Contributors - [@10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [pinojs/pino#1859 - [@Zamiell](https://togithub.com/Zamiell) made their first contribution in [pinojs/pino#1783 **Full Changelog**: pinojs/pino@v8.16.2...v8.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10am on Friday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ettorepuccetti/terrarossa).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`^8.16.2` -> `^8.17.2`](https://renovatebot.com/diffs/npm/pino/8.16.2/8.17.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.17.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.17.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.16.2/8.17.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.16.2/8.17.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.17.2`](https://togithub.com/pinojs/pino/releases/tag/v8.17.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.1...v8.17.2) #### What's Changed - build(deps): bump process-warning from 2.3.2 to 3.0.0 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1869 - fix: type of child logger with custom levels by [@UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [pinojs/pino#1871 **Full Changelog**: pinojs/pino@v8.17.1...v8.17.2 ### [`v8.17.1`](https://togithub.com/pinojs/pino/releases/tag/v8.17.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.0...v8.17.1) #### What's Changed - Support unknown, reverts 1783, add tests by [@mcollina](https://togithub.com/mcollina) in [pinojs/pino#1866 - Add Type Example for custom logger by [@mcollina](https://togithub.com/mcollina) in [pinojs/pino#1867 **Full Changelog**: pinojs/pino@v8.17.0...v8.17.1 ### [`v8.17.0`](https://togithub.com/pinojs/pino/releases/tag/v8.17.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.16.2...v8.17.0) #### What's Changed - build(deps): bump actions/github-script from 6 to 7 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1857 - Make license detectable by GitHub by [@10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [pinojs/pino#1859 - docs: Clarify how to log both to a custom transport and to stdout by [@kibertoad](https://togithub.com/kibertoad) in [pinojs/pino#1860 - Fix/types by [@UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [pinojs/pino#1858 - Bumped tsd to v0.29.0 by [@mcollina](https://togithub.com/mcollina) in [pinojs/pino#1863 - fix: typescript types by [@Zamiell](https://togithub.com/Zamiell) in [pinojs/pino#1783 - build(deps): bump pnpm/action-setup from 2.2.4 to 2.4.0 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1766 #### New Contributors - [@10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [pinojs/pino#1859 - [@Zamiell](https://togithub.com/Zamiell) made their first contribution in [pinojs/pino#1783 **Full Changelog**: pinojs/pino@v8.16.2...v8.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/fwouts/previewjs).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.16.2` -> `8.19.0`](https://renovatebot.com/diffs/npm/pino/8.16.2/8.19.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.16.2/8.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.16.2/8.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.19.0`](https://togithub.com/pinojs/pino/releases/tag/v8.19.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.18.0...v8.19.0) #### What's Changed - api.md: Fix link declaration by [@homersimpsons](https://togithub.com/homersimpsons) in [pinojs/pino#1900 - Update transports.md by [@huijiewei](https://togithub.com/huijiewei) in [pinojs/pino#1897 - Add a basic `formatters` option to the browser pino by [@KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1898 - `setLevel` should respect level comparison option by [@obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1901 - Add formatters log option by [@KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1905 #### New Contributors - [@homersimpsons](https://togithub.com/homersimpsons) made their first contribution in [pinojs/pino#1900 - [@huijiewei](https://togithub.com/huijiewei) made their first contribution in [pinojs/pino#1897 - [@KatelynKim](https://togithub.com/KatelynKim) made their first contribution in [pinojs/pino#1898 **Full Changelog**: pinojs/pino@v8.18.0...v8.19.0 ### [`v8.18.0`](https://togithub.com/pinojs/pino/releases/tag/v8.18.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.2...v8.18.0) #### What's Changed - build(deps): bump actions/upload-artifact from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1873 - chore(license): Update licensing year by [@codershiba](https://togithub.com/codershiba) in [pinojs/pino#1882 - fix: destination docs and types by [@codershiba](https://togithub.com/codershiba) in [pinojs/pino#1881 - Correct type of `pino`'s `stream` parameter by [@quisido](https://togithub.com/quisido) in [pinojs/pino#1874 - Add ability to override custom levels comparison by [@obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1883 - build(deps-dev): bump tsd from 0.29.0 to 0.30.4 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1888 #### New Contributors - [@codershiba](https://togithub.com/codershiba) made their first contribution in [pinojs/pino#1882 - [@quisido](https://togithub.com/quisido) made their first contribution in [pinojs/pino#1874 - [@obrus-corcentric](https://togithub.com/obrus-corcentric) made their first contribution in [pinojs/pino#1883 **Full Changelog**: pinojs/pino@v8.17.2...v8.18.0 ### [`v8.17.2`](https://togithub.com/pinojs/pino/releases/tag/v8.17.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.1...v8.17.2) #### What's Changed - build(deps): bump process-warning from 2.3.2 to 3.0.0 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1869 - fix: type of child logger with custom levels by [@UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [pinojs/pino#1871 **Full Changelog**: pinojs/pino@v8.17.1...v8.17.2 ### [`v8.17.1`](https://togithub.com/pinojs/pino/releases/tag/v8.17.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.0...v8.17.1) #### What's Changed - Support unknown, reverts 1783, add tests by [@mcollina](https://togithub.com/mcollina) in [pinojs/pino#1866 - Add Type Example for custom logger by [@mcollina](https://togithub.com/mcollina) in [pinojs/pino#1867 **Full Changelog**: pinojs/pino@v8.17.0...v8.17.1 ### [`v8.17.0`](https://togithub.com/pinojs/pino/releases/tag/v8.17.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.16.2...v8.17.0) #### What's Changed - build(deps): bump actions/github-script from 6 to 7 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1857 - Make license detectable by GitHub by [@10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [pinojs/pino#1859 - docs: Clarify how to log both to a custom transport and to stdout by [@kibertoad](https://togithub.com/kibertoad) in [pinojs/pino#1860 - Fix/types by [@UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [pinojs/pino#1858 - Bumped tsd to v0.29.0 by [@mcollina](https://togithub.com/mcollina) in [pinojs/pino#1863 - fix: typescript types by [@Zamiell](https://togithub.com/Zamiell) in [pinojs/pino#1783 - build(deps): bump pnpm/action-setup from 2.2.4 to 2.4.0 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1766 #### New Contributors - [@10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [pinojs/pino#1859 - [@Zamiell](https://togithub.com/Zamiell) made their first contribution in [pinojs/pino#1783 **Full Changelog**: pinojs/pino@v8.16.2...v8.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: David Price <thedavid@thedavidprice.com>

mcollina added 3 commits December 14, 2023 10:09

Revert "fix: typescript types (#1783)"

c372b9c

This reverts commit 7f739d3.

Add check

ddd8cbc

Signed-off-by: Matteo Collina <hello@matteocollina.com>

fixup

1a3a07c

Signed-off-by: Matteo Collina <hello@matteocollina.com>

kibertoad approved these changes Dec 14, 2023

View reviewed changes

mcollina changed the title ~~Revert ts change~~ Support unknown, reverts 1783, add tests Dec 14, 2023

mcollina mentioned this pull request Dec 14, 2023

Pino 8.17.0 breaks logging from catch in TypeScript #1865

Closed

mcollina merged commit 6b470c1 into master Dec 14, 2023
20 of 21 checks passed

mcollina deleted the revert-ts-change branch December 14, 2023 09:28

bilelsalemdev mentioned this pull request May 20, 2024

[Snyk] Upgrade pino from 8.10.0 to 8.21.0 bilelsalemdev/post-comment-api#24

Open

This was referenced May 23, 2024

[Snyk] Upgrade pino from 8.9.0 to 8.21.0 gptkrsh/LinkFree#511

Open

[Snyk] Upgrade pino from 8.9.0 to 8.21.0 gptkrsh/LinkFree#522

Open

bilelsalemdev mentioned this pull request May 24, 2024

[Snyk] Upgrade pino from 8.10.0 to 8.21.0 bilelsalemdev/post-comment-api#27

Open

OKEAMAH mentioned this pull request May 26, 2024

[Snyk] Upgrade pino from 7.11.0 to 9.0.0 OKEAMAH/hedera-json-rpc-relay#28

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support unknown, reverts 1783, add tests #1866

Support unknown, reverts 1783, add tests #1866

mcollina commented Dec 14, 2023 •

edited

mcollina commented Dec 14, 2023

Support unknown, reverts 1783, add tests #1866

Support unknown, reverts 1783, add tests #1866

Conversation

mcollina commented Dec 14, 2023 • edited

mcollina commented Dec 14, 2023

mcollina commented Dec 14, 2023 •

edited