setLevel should respect level comparison option
#1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners
reviewed
Feb 10, 2024
renovate bot
added a commit
to fwouts/previewjs
that referenced
this pull request
Feb 17, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`^8.18.0` -> `^8.19.0`](https://renovatebot.com/diffs/npm/pino/8.18.0/8.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.19.0`](https://togithub.com/pinojs/pino/releases/tag/v8.19.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.18.0...v8.19.0) #### What's Changed - api.md: Fix link declaration by [@​homersimpsons](https://togithub.com/homersimpsons) in [pinojs/pino#1900 - Update transports.md by [@​huijiewei](https://togithub.com/huijiewei) in [pinojs/pino#1897 - Add a basic `formatters` option to the browser pino by [@​KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1898 - `setLevel` should respect level comparison option by [@​obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1901 - Add formatters log option by [@​KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1905 #### New Contributors - [@​homersimpsons](https://togithub.com/homersimpsons) made their first contribution in [pinojs/pino#1900 - [@​huijiewei](https://togithub.com/huijiewei) made their first contribution in [pinojs/pino#1897 - [@​KatelynKim](https://togithub.com/KatelynKim) made their first contribution in [pinojs/pino#1898 **Full Changelog**: pinojs/pino@v8.18.0...v8.19.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/fwouts/previewjs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to redwoodjs/redwood
that referenced
this pull request
Mar 19, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.16.2` -> `8.19.0`](https://renovatebot.com/diffs/npm/pino/8.16.2/8.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.19.0`](https://togithub.com/pinojs/pino/releases/tag/v8.19.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.18.0...v8.19.0) #### What's Changed - api.md: Fix link declaration by [@​homersimpsons](https://togithub.com/homersimpsons) in [pinojs/pino#1900 - Update transports.md by [@​huijiewei](https://togithub.com/huijiewei) in [pinojs/pino#1897 - Add a basic `formatters` option to the browser pino by [@​KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1898 - `setLevel` should respect level comparison option by [@​obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1901 - Add formatters log option by [@​KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1905 #### New Contributors - [@​homersimpsons](https://togithub.com/homersimpsons) made their first contribution in [pinojs/pino#1900 - [@​huijiewei](https://togithub.com/huijiewei) made their first contribution in [pinojs/pino#1897 - [@​KatelynKim](https://togithub.com/KatelynKim) made their first contribution in [pinojs/pino#1898 **Full Changelog**: pinojs/pino@v8.18.0...v8.19.0 ### [`v8.18.0`](https://togithub.com/pinojs/pino/releases/tag/v8.18.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.2...v8.18.0) #### What's Changed - build(deps): bump actions/upload-artifact from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1873 - chore(license): Update licensing year by [@​codershiba](https://togithub.com/codershiba) in [pinojs/pino#1882 - fix: destination docs and types by [@​codershiba](https://togithub.com/codershiba) in [pinojs/pino#1881 - Correct type of `pino`'s `stream` parameter by [@​quisido](https://togithub.com/quisido) in [pinojs/pino#1874 - Add ability to override custom levels comparison by [@​obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1883 - build(deps-dev): bump tsd from 0.29.0 to 0.30.4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1888 #### New Contributors - [@​codershiba](https://togithub.com/codershiba) made their first contribution in [pinojs/pino#1882 - [@​quisido](https://togithub.com/quisido) made their first contribution in [pinojs/pino#1874 - [@​obrus-corcentric](https://togithub.com/obrus-corcentric) made their first contribution in [pinojs/pino#1883 **Full Changelog**: pinojs/pino@v8.17.2...v8.18.0 ### [`v8.17.2`](https://togithub.com/pinojs/pino/releases/tag/v8.17.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.1...v8.17.2) #### What's Changed - build(deps): bump process-warning from 2.3.2 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1869 - fix: type of child logger with custom levels by [@​UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [pinojs/pino#1871 **Full Changelog**: pinojs/pino@v8.17.1...v8.17.2 ### [`v8.17.1`](https://togithub.com/pinojs/pino/releases/tag/v8.17.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.0...v8.17.1) #### What's Changed - Support unknown, reverts 1783, add tests by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1866 - Add Type Example for custom logger by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1867 **Full Changelog**: pinojs/pino@v8.17.0...v8.17.1 ### [`v8.17.0`](https://togithub.com/pinojs/pino/releases/tag/v8.17.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.16.2...v8.17.0) #### What's Changed - build(deps): bump actions/github-script from 6 to 7 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1857 - Make license detectable by GitHub by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [pinojs/pino#1859 - docs: Clarify how to log both to a custom transport and to stdout by [@​kibertoad](https://togithub.com/kibertoad) in [pinojs/pino#1860 - Fix/types by [@​UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [pinojs/pino#1858 - Bumped tsd to v0.29.0 by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1863 - fix: typescript types by [@​Zamiell](https://togithub.com/Zamiell) in [pinojs/pino#1783 - build(deps): bump pnpm/action-setup from 2.2.4 to 2.4.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1766 #### New Contributors - [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [pinojs/pino#1859 - [@​Zamiell](https://togithub.com/Zamiell) made their first contribution in [pinojs/pino#1783 **Full Changelog**: pinojs/pino@v8.16.2...v8.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: David Price <thedavid@thedavidprice.com>
thedavidprice
added a commit
to redwoodjs/redwood
that referenced
this pull request
Mar 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.16.2` -> `8.19.0`](https://renovatebot.com/diffs/npm/pino/8.16.2/8.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.19.0`](https://togithub.com/pinojs/pino/releases/tag/v8.19.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.18.0...v8.19.0) #### What's Changed - api.md: Fix link declaration by [@​homersimpsons](https://togithub.com/homersimpsons) in [pinojs/pino#1900 - Update transports.md by [@​huijiewei](https://togithub.com/huijiewei) in [pinojs/pino#1897 - Add a basic `formatters` option to the browser pino by [@​KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1898 - `setLevel` should respect level comparison option by [@​obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1901 - Add formatters log option by [@​KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1905 #### New Contributors - [@​homersimpsons](https://togithub.com/homersimpsons) made their first contribution in [pinojs/pino#1900 - [@​huijiewei](https://togithub.com/huijiewei) made their first contribution in [pinojs/pino#1897 - [@​KatelynKim](https://togithub.com/KatelynKim) made their first contribution in [pinojs/pino#1898 **Full Changelog**: pinojs/pino@v8.18.0...v8.19.0 ### [`v8.18.0`](https://togithub.com/pinojs/pino/releases/tag/v8.18.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.2...v8.18.0) #### What's Changed - build(deps): bump actions/upload-artifact from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1873 - chore(license): Update licensing year by [@​codershiba](https://togithub.com/codershiba) in [pinojs/pino#1882 - fix: destination docs and types by [@​codershiba](https://togithub.com/codershiba) in [pinojs/pino#1881 - Correct type of `pino`'s `stream` parameter by [@​quisido](https://togithub.com/quisido) in [pinojs/pino#1874 - Add ability to override custom levels comparison by [@​obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1883 - build(deps-dev): bump tsd from 0.29.0 to 0.30.4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1888 #### New Contributors - [@​codershiba](https://togithub.com/codershiba) made their first contribution in [pinojs/pino#1882 - [@​quisido](https://togithub.com/quisido) made their first contribution in [pinojs/pino#1874 - [@​obrus-corcentric](https://togithub.com/obrus-corcentric) made their first contribution in [pinojs/pino#1883 **Full Changelog**: pinojs/pino@v8.17.2...v8.18.0 ### [`v8.17.2`](https://togithub.com/pinojs/pino/releases/tag/v8.17.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.1...v8.17.2) #### What's Changed - build(deps): bump process-warning from 2.3.2 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1869 - fix: type of child logger with custom levels by [@​UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [pinojs/pino#1871 **Full Changelog**: pinojs/pino@v8.17.1...v8.17.2 ### [`v8.17.1`](https://togithub.com/pinojs/pino/releases/tag/v8.17.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.0...v8.17.1) #### What's Changed - Support unknown, reverts 1783, add tests by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1866 - Add Type Example for custom logger by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1867 **Full Changelog**: pinojs/pino@v8.17.0...v8.17.1 ### [`v8.17.0`](https://togithub.com/pinojs/pino/releases/tag/v8.17.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.16.2...v8.17.0) #### What's Changed - build(deps): bump actions/github-script from 6 to 7 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1857 - Make license detectable by GitHub by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [pinojs/pino#1859 - docs: Clarify how to log both to a custom transport and to stdout by [@​kibertoad](https://togithub.com/kibertoad) in [pinojs/pino#1860 - Fix/types by [@​UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [pinojs/pino#1858 - Bumped tsd to v0.29.0 by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1863 - fix: typescript types by [@​Zamiell](https://togithub.com/Zamiell) in [pinojs/pino#1783 - build(deps): bump pnpm/action-setup from 2.2.4 to 2.4.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1766 #### New Contributors - [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [pinojs/pino#1859 - [@​Zamiell](https://togithub.com/Zamiell) made their first contribution in [pinojs/pino#1783 **Full Changelog**: pinojs/pino@v8.16.2...v8.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: David Price <thedavid@thedavidprice.com>
renovate bot
added a commit
to ettorepuccetti/terrarossa
that referenced
this pull request
Mar 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.17.2` -> `8.19.0`](https://renovatebot.com/diffs/npm/pino/8.17.2/8.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.19.0`](https://togithub.com/pinojs/pino/releases/tag/v8.19.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.18.0...v8.19.0) #### What's Changed - api.md: Fix link declaration by [@​homersimpsons](https://togithub.com/homersimpsons) in [pinojs/pino#1900 - Update transports.md by [@​huijiewei](https://togithub.com/huijiewei) in [pinojs/pino#1897 - Add a basic `formatters` option to the browser pino by [@​KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1898 - `setLevel` should respect level comparison option by [@​obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1901 - Add formatters log option by [@​KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1905 #### New Contributors - [@​homersimpsons](https://togithub.com/homersimpsons) made their first contribution in [pinojs/pino#1900 - [@​huijiewei](https://togithub.com/huijiewei) made their first contribution in [pinojs/pino#1897 - [@​KatelynKim](https://togithub.com/KatelynKim) made their first contribution in [pinojs/pino#1898 **Full Changelog**: pinojs/pino@v8.18.0...v8.19.0 ### [`v8.18.0`](https://togithub.com/pinojs/pino/releases/tag/v8.18.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.2...v8.18.0) #### What's Changed - build(deps): bump actions/upload-artifact from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1873 - chore(license): Update licensing year by [@​codershiba](https://togithub.com/codershiba) in [pinojs/pino#1882 - fix: destination docs and types by [@​codershiba](https://togithub.com/codershiba) in [pinojs/pino#1881 - Correct type of `pino`'s `stream` parameter by [@​quisido](https://togithub.com/quisido) in [pinojs/pino#1874 - Add ability to override custom levels comparison by [@​obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1883 - build(deps-dev): bump tsd from 0.29.0 to 0.30.4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1888 #### New Contributors - [@​codershiba](https://togithub.com/codershiba) made their first contribution in [pinojs/pino#1882 - [@​quisido](https://togithub.com/quisido) made their first contribution in [pinojs/pino#1874 - [@​obrus-corcentric](https://togithub.com/obrus-corcentric) made their first contribution in [pinojs/pino#1883 **Full Changelog**: pinojs/pino@v8.17.2...v8.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10am on Friday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ettorepuccetti/terrarossa). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced May 23, 2024
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mcollina @jsumners
Previous PR #1883 contained only a half of a change, i just realized that
setLevelalso should respectlevelComparison, not onlyisLevelEnabled