Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pino types for browser.formatters #1946

Merged
merged 2 commits into from Apr 28, 2024
Merged

Update pino types for browser.formatters #1946

merged 2 commits into from Apr 28, 2024

Conversation

KatelynKim
Copy link
Contributor

@KatelynKim KatelynKim commented Apr 22, 2024 •
edited

Add the missing types for the browser.formatters option.

mcollina
mcollina requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for these types? We use tsd.

@KatelynKim
Copy link
Contributor Author

Can you add a test for these types? We use tsd.

Hello, I added a test. Could you please check? Thank you!

mcollina
mcollina approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit b50d02b into pinojs:master Apr 28, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KatelynKim @mcollina