Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue v9 release #1947

Merged
merged 5 commits into from Apr 24, 2024
Merged

Issue v9 release #1947

merged 5 commits into from Apr 24, 2024

Conversation

jsumners
Copy link
Member

Once merged and published, the LTS doc needs to be updated with new dates.

I wanted to resolve #1762 before doing this, but it's just too much work for (effectively) two people with a lot else going on. Basically, keeping up with all of the next branches and conflicts (I already need to update the work I did a few weeks ago on pino-abstract-transport) is out of our reach. I have come to the conclusion that we just need to issue v9, and then chip away at #1762. It'll be easier on us.

@jsumners jsumners requested a review from mcollina April 24, 2024 02:09
@@ -43,6 +43,7 @@ A "month" is defined as 30 consecutive days.

| Version | Release Date | End Of LTS Date | Node.js |
| :------ | :----------- | :-------------- | :------------------- |
| 9.x | TBD. | TBD | 18, 20 |
| 8.x | 2022-06-01 | TBD | 14, 16, 18 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| 8.x | 2022-06-01 | TBD | 14, 16, 18 |
| 8.x | 2022-06-01 | TBD | 14, 16, 18, 20 |

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll ship #1930 in a minor and then we can ship this. Ok?

@jsumners
Copy link
Member Author

Sounds good. Ship this when you're ready or I'll get to it sometime after work.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina merged commit 4f8ea32 into master Apr 24, 2024
13 checks passed
@mcollina mcollina deleted the cut-v9 branch April 24, 2024 14:41
@jlowcs
Copy link

jlowcs commented Apr 25, 2024

I'm not seeing a Changelog anywhere for v9? Am I missing something?

@arthurfiorette
Copy link

What's the breaking change of v9?

@mcollina
Copy link
Member

drop support of Node < latest v18.

@joostdecock
Copy link

drop support of Node < latest v18.

Thanks, came here looking for this info, trying to figure out whether it was safe to upgrade.

The release notes state:

Dropped support for Node.js 14, 16, & 19

Which I found a bit confusing when trying to figure out whether v18 is still supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update modules for v9
5 participants