Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transport-stream): Fix import error when using pkg with node v20 #1949

Merged
merged 1 commit into from Apr 27, 2024

Conversation

nagyszabi
Copy link
Contributor

Fixes: #1948

Note:
Because the changes to thread-stream aren't published yet, tests will fail.
I tested the code locally, where I manually changed the thread-stream package in order to be able to test the changes.

@mcollina
Copy link
Member

mcollina commented Apr 24, 2024

released

@nagyszabi
Copy link
Contributor Author

Thank you!

Could you please re-run the tests so I can check if everything's alright? (I don't see an option to re-run them myself)

@mcollina
Copy link
Member

It’s failing unfortunately

@nagyszabi
Copy link
Contributor Author

I fixed the errors for Node v21. I was checking for stderr to be an empty string but it turns out it's a deprecation warning for punnycode:

(node:1234) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

So I added a regex test which checks exactly the warning above. Anything else will fail the test.

For Node 18 on MacOS I assume it's not related to my commit since it fails on another test, which works in Linux and Windows.

But please run the tests again, and if there is a problem on MacOS I'll look deeper into it. Thank you!

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit dbab33b into pinojs:master Apr 27, 2024
12 of 13 checks passed
@nagyszabi nagyszabi deleted the fix-pkg-with-node-20#1948 branch April 29, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import error when using worker with pkg
2 participants