run ci on node 22

Signed-off-by: Matteo Collina <hello@matteocollina.com>
pinojs · Apr 27, 2024 · f64c271 · f64c271
1 parent 87cfbe7
commit f64c271
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -38,7 +38,7 @@ jobs:
       contents: read
     strategy:
       matrix:
-        node-version: [14, 16, 18, 20]
+        node-version: [18, 20, 22]
         os: [macos-latest, ubuntu-latest, windows-latest]
         exclude:
           - os: windows-latest

diff --git a/lib/worker.js b/lib/worker.js
@@ -159,7 +159,6 @@ process.once('exit', exitCode => {
     process.exit(exitCode)
     return
   }
-
   if (destination?.writableNeedDrain && !destination?.writableEnded) {
     parentPort.postMessage({
       code: 'WARNING',

diff --git a/test/pkg/pkg.test.js b/test/pkg/pkg.test.js
@@ -14,6 +14,8 @@ test('worker test when packaged into executable using pkg', async (t) => {
   // package the app into several node versions, check config for more info
   const filePath = `${join(__dirname, packageName)}.js`
   const configPath = join(__dirname, 'pkg.config.json')
+  process.env.NODE_OPTIONS ||= ''
+  process.env.NODE_OPTIONS = '--no-warnings'
   const { stderr } = await exec(`npx pkg ${filePath} --config ${configPath}`)
 
   // there should be no error when packaging