Skip to content

Commit

Permalink
Internal: Upgrade to Node 20 (#3563)
Browse files Browse the repository at this point in the history
Co-authored-by: Raviteja Lingineni <rlingineni@live.com>
  • Loading branch information
jackhsu978 and rlingineni committed May 13, 2024
1 parent 734d7e3 commit ef3a220
Show file tree
Hide file tree
Showing 8 changed files with 743 additions and 242 deletions.
4 changes: 2 additions & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "Gestalt: Node.js 16",
"name": "Gestalt: Node.js 20",
// https://github.com/microsoft/vscode-dev-containers/tree/main/containers/javascript-node
"image": "mcr.microsoft.com/vscode/devcontainers/javascript-node:16",
"image": "mcr.microsoft.com/vscode/devcontainers/javascript-node:20",

// Set *default* container specific settings.json values on container create.
"settings": {
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/alpha.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20
- name: Setup npm
env:
NODE_AUTH_TOKEN: ${{ secrets.ALBERTO_NPM_PERSONAL_TOKEN }}
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,11 @@ jobs:
test:
name: Tests
runs-on: ubuntu-latest
strategy:
matrix:
node_version: [16, 18]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node_version }}
node-version: 20
- id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '16'
node-version: 20
cache: 'yarn'
- name: Install dependencies
run: yarn install --frozen-lockfile
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20
- name: Setup npm
env:
NODE_AUTH_TOKEN: ${{ secrets.ALBERTO_NPM_PERSONAL_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
20
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@babel/preset-react": "^7.13.13",
"@babel/register": "^7.11.5",
"@codesandbox/sandpack-react": "^2.6.0",
"@netlify/plugin-nextjs": "^4.29.2",
"@netlify/plugin-nextjs": "^4.41.3",
"@next/eslint-plugin-next": "^12.2.0",
"@playwright/test": "^1.37.1",
"@rollup/plugin-babel": "^5.3.0",
Expand All @@ -47,6 +47,7 @@
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-flowtype": "^8.0.3",
"eslint-plugin-gestalt": ">0.0.0",
"eslint-plugin-import": "^2.25.2",
"eslint-plugin-jest": "^26.1.5",
"eslint-plugin-jsx-a11y": "^6.5.1",
Expand All @@ -59,7 +60,6 @@
"flow-bin": "^0.216.1",
"flow-remove-types": "^2.184.0",
"flow-upgrade": "^2.2.0",
"eslint-plugin-gestalt": ">0.0.0",
"identity-obj-proxy": "^3.0.0",
"jest": "28.0.3",
"jest-environment-jsdom": "^28.0.2",
Expand Down

0 comments on commit ef3a220

Please sign in to comment.