DefaultLabelProvider: Add collapsible SideNavigation accessibility labels #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gestalt ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
willsmanley
reviewed
Mar 25, 2024
willsmanley
reviewed
Mar 25, 2024
Comment on lines
+496
to
+498
| accessibilityCollapseButtonLabel: string; | ||
| accessibilityExpandButtonLabel: string; | ||
| accessibilityEllipsisLabel: string; |
There was a problem hiding this comment.
i think we need to update packages/gestalt/src/contexts/DefaultLabelProvider.jsdom.test.js as well
There was a problem hiding this comment.
and docs here: docs/examples/defaultlabelprovider/translations.js
There was a problem hiding this comment.
Whole discussion here https://pinterest.slack.com/archives/G01GN7CE99S/p1711367607564319
rlingineni
changed the title
rlingineni
changed the title
AlbertCarreras
changed the title
AlbertCarreras
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added type definitions for the collapsible SideNavigation default accesssibility labels.
Links
Checklist