Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: add temporary files to ignore lists #3568

Merged
merged 2 commits into from
May 15, 2024

Conversation

jackhsu978
Copy link
Member

What changed?

Add temporary files to ignore list:

  • coverage/
  • .rollup.cache/
  • *.tsbuildinfo

Why?

These files get auto-generated when we run CI commands (or tsc for TypeScript type checking) locally, and we should generally ignore these files (when we lint, format, commit, ...etc)

@jackhsu978 jackhsu978 added the patch release Patch release label May 14, 2024
@jackhsu978 jackhsu978 requested a review from a team as a code owner May 14, 2024 22:03
@jackhsu978 jackhsu978 enabled auto-merge (squash) May 14, 2024 22:03
Copy link

netlify bot commented May 14, 2024

Deploy Preview for gestalt ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 78df4f5
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/6643dfa8137ace0008147ed7
😎 Deploy Preview https://deploy-preview-3568--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@AlbertCarreras AlbertCarreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jackhsu978 jackhsu978 merged commit 588deca into pinterest:master May 15, 2024
15 checks passed
@jackhsu978 jackhsu978 deleted the ts-ignore-files branch May 21, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Patch release
Projects
None yet
2 participants