Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing commas in enums #1542

Merged
merged 6 commits into from Aug 3, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -1021,4 +1021,52 @@ class TrailingCommaRuleTest {
LintViolation(7, 6, "Missing trailing comma before \")\"")
).isFormattedAs(formattedCode)
}

@Test
fun `Given that a trailing comma is required then add trailing comma after last enum member`() {
val code =
"""
enum class Shape {
SQUARE,
TRIANGLE
}
""".trimIndent()
val formattedCode =
"""
enum class Shape {
SQUARE,
TRIANGLE,
}
""".trimIndent()

trailingCommaRuleAssertThat(code)
.withEditorConfigOverride(allowTrailingCommaProperty to true)
.hasLintViolations(
LintViolation(3, 12, "Missing trailing comma before \"}\"") // TODO
).isFormattedAs(formattedCode)
Kantis marked this conversation as resolved.
Show resolved Hide resolved
}

@Test
fun `Given that a trailing comma is is not allowed then remove comma after last enum member`() {
val code =
"""
enum class Shape {
SQUARE,
TRIANGLE,
}
""".trimIndent()
val formattedCode =
"""
enum class Shape {
SQUARE,
TRIANGLE
}
""".trimIndent()

trailingCommaRuleAssertThat(code)
.withEditorConfigOverride(allowTrailingCommaProperty to true)
Kantis marked this conversation as resolved.
Show resolved Hide resolved
.hasLintViolations(
LintViolation(3, 12, "Unnecessary trailing comma before \"}\"") // TODO
).isFormattedAs(formattedCode)
Kantis marked this conversation as resolved.
Show resolved Hide resolved
}
}