Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use sed entirely with regex to get the java major version #1544

Merged
merged 4 commits into from
Jul 21, 2022
Merged

use sed entirely with regex to get the java major version #1544

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4436efa
use sed entirely with regex to get the java major version
rawilder Jul 13, 2022
c1662bd
changelog updated
rawilder Jul 13, 2022
3d23ad5
changelog wording
rawilder Jul 14, 2022
db8a985
Merge branch 'master' into get-jv-with-sed-only
paul-dingemans Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
### Fixed

* Fix cli argument "--disabled_rules" ([#1520](https://github.com/pinterest/ktlint/issue/1520)).
* Fix incorrect JV when JAVA_TOOL_OPTIONS is set in env ([#1543](https://github.com/pinterest/ktlint/issues/1543))
rawilder marked this conversation as resolved.
Show resolved Hide resolved

### Changed

Expand Down
2 changes: 1 addition & 1 deletion ktlint/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ val shadowJarExecutable by tasks.registering(DefaultTask::class) {
// Then if that java version is >= 16, we add the --add-opens command
// X = X=$( [ "$JV" -ge "16" ] && echo "--add-opens java.base/java.lang=ALL-UNNAMED" || echo "")
// exec java $X -Xmx512m -jar "$0" "$@"
execFile.appendText("#!/bin/sh\n\nJV=\$(java -version 2>&1 | head -1 | cut -d'\"' -f2 | sed '/^1\\./s///' | cut -d'.' -f1)\n\nX=\$( [ \"\$JV\" -ge \"16\" ] && echo \"--add-opens java.base/java.lang=ALL-UNNAMED\" || echo \"\")\n\nexec java \$X -Xmx512m -jar \"\$0\" \"\$@\"\n\n")
execFile.appendText("#!/bin/sh\n\nJV=\$(java -version 2>&1 | sed -E -n 's/.* version \"([^.-]*).*\".*/\\1/p')\n\nX=\$( [ \"\$JV\" -ge \"16\" ] && echo \"--add-opens java.base/java.lang=ALL-UNNAMED\" || echo \"\")\n\nexec java \$X -Xmx512m -jar \"\$0\" \"\$@\"\n\n")
paul-dingemans marked this conversation as resolved.
Show resolved Hide resolved
execFile.appendBytes(inputs.files.singleFile.readBytes())
execFile.setExecutable(true, false)
if (!version.toString().endsWith("SNAPSHOT")) {
Expand Down