Split TrailingCommaRule

[chao2zhang]

Fix #1552

Description

Split TrailingCommaRule into OnDeclarationSite and OnCallSite

Checklist

• PR description added
• tests are added
• CHANGELOG.md is updated

In case of adding a new rule:

• README.md is updated
• Rule has been applied on Ktlint itself and violations are fixed

[paul-dingemans]

Tnx for the contribution. Please address the review remarks.

[paul-dingemans]

Also the documentation pages (not yet formally announced) need to be updated. See file https://github.com/pinterest/ktlint/blob/master/docs/rules/standard.md

New documentation has been released and changed in your branch as well. Can you please update new docs, if not yet done so?

[paul-dingemans]

I just bumped into test Given an enumeration and the list of values is closed with a semicolon not followed by statements then do not return a lint error. The semi colon after the enum must exist in the AST as in this test the unnecessary semicolon is reported.

[chao2zhang]

I just bumped into test Given an enumeration and the list of values is closed with a semicolon not followed by statements then do not return a lint error. The semi colon after the enum must exist in the AST as in this test the unnecessary semicolon is reported.

I am not sure if this is intended for this PR - All the CI checks are passing for me this time with the refactoring as suggested.

[paul-dingemans]

I just bumped into test Given an enumeration and the list of values is closed with a semicolon not followed by statements then do not return a lint error. The semi colon after the enum must exist in the AST as in this test the unnecessary semicolon is reported.

I am not sure if this is intended for this PR - All the CI checks are passing for me this time with the refactoring as suggested.

Sorry, this remark was meant for the PR regarding the enums and trailing comma's.

[paul-dingemans]

@chao2zhang The Trailing comma in enum PR has been merged. Changes are non-trivial, so please be careful with merging changes to your branch.