Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AnnotationRule to improve maintainability #1574

Merged

Commits on Aug 6, 2022

  1. Refactor AnnotationRule to improve maintainability

    Replace (biggest part of) processing of MODIFIER_LIST and FILE_ANNOTATION_LIST with processing of
    individual ANNOTATION_ENTRY. This allows ANNOTATION_ENTRY to be followed by EOL_COMMENT plus
    another ANNOTATION_ENTRY.
    
    Reword the violations to be more clear.
    
    Annotation with parameter(s) on same line as annotated construct is rewritten to
    annotation on a separate line directly as otherwise a lint violation would remain
    after the first format.
    
    Closes pinterest#1539
    paul-dingemans committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    ae88d15 View commit details
    Browse the repository at this point in the history
  2. update changelog

    paul-dingemans committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    52222b2 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2022

  1. Configuration menu
    Copy the full SHA
    79f3de0 View commit details
    Browse the repository at this point in the history