Add CLI option `--log-level=<level>' #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with `--log-level=<level>` or the short version `-l=<level>. Closes pinterest#1632 * Allow disabling logging in CLI by setting `--log-level=none` or `-l=none`. Closes pinterest#1652
Goooler
reviewed
Oct 5, 2022
build.gradle
Outdated
Comment on lines
37
to
42
| // Experimental rules run by default run on the ktlint code base itself. Experimental rules should not be released | ||
| // if we are not pleased ourselves with the results on the ktlint code base. | ||
| '--experimental', | ||
| // Run with log-level error so that all lint violations can be spotted easily and are not drowned in a lot of log | ||
| // lines. | ||
| '--log-level=error' |
There was a problem hiding this comment.
Seems this change needs to resolve conflicts with 28ff448, should add a trailing comma after '--log-level=error'.
There was a problem hiding this comment.
Yes, I noted that as well when I was reviewing the code. Tnx for notifying it as well.
# Conflicts: # CHANGELOG.md # build.gradle # ktlint-ruleset-template/build.gradle.kts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description
Replace CLI options
--debug,--trace,--verboseand-vare with--log-level=<level>or the short version `-l=.Closes #1632
--log-level=noneor-l=none.Closes #1652
Checklist
CHANGELOG.mdis updatedIn case of adding a new rule: