Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replacement of redundant curly braces #2617

Merged
merged 1 commit into from Apr 6, 2024

Conversation

paul-dingemans
Copy link
Collaborator

@paul-dingemans paul-dingemans commented Mar 24, 2024

Description

Due to incorrect construction of the string template, it could happen that an import is removed as it was falsely flagged as unused as the "$" was added as prefix in the identifier.

Closes #2615

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

Due to incorrect construction of the string template, it could happen that an import is removed as it was falsely flagged as unused as the "$" was added as prefix in the identifier.
@paul-dingemans paul-dingemans added this to the 1.2.2 milestone Mar 24, 2024
@paul-dingemans paul-dingemans merged commit 9234dec into master Apr 6, 2024
12 checks passed
@paul-dingemans paul-dingemans deleted the 2615-string-template branch April 6, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import incorrectly dropped when correcting string template expression with redundant braces
1 participant