Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of IDE integration via editorconfig #874

Merged
merged 9 commits into from
Sep 18, 2020
Merged

Initial implementation of IDE integration via editorconfig #874

merged 9 commits into from
Sep 18, 2020

Commits on Sep 8, 2020

  1. Introduce opt-in features annotations. 

    Two annotations:
- feature in alpha state - this is highly experimental feature that will change in the future.
- feature in beta state - experimental feature that may have some bugs.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
    @Tapchicoma
    Tapchicoma committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    4596252 View commit details
    Browse the repository at this point in the history

  2. Introduce UsesEditorconfigProperties interface. 

    This interface should be used by rules to provide default editorconfig properties. This is used to generate missing properties for .editorconfig and enable better integration with IDE.

Feature is set to be in alpha state.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
    @Tapchicoma
    Tapchicoma committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    7fbde3f View commit details
    Browse the repository at this point in the history

  3. Add support for editorconfig generation in 'final-newline' rule. 

    Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
    @Tapchicoma
    Tapchicoma committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    aa8f239 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Add new helper EditorConfigTestRule rule. 

    Should simplify writing tests for rules implementing UsesEditorConfigProperty interface.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
    @Tapchicoma
    Tapchicoma committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    db6a90a View commit details
    Browse the repository at this point in the history

  2. Add two new extension methods accepting path to linted file. 

    This will allow to load written by test case `.editorconfig` file.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
    @Tapchicoma
    Tapchicoma committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    5975dd2 View commit details
    Browse the repository at this point in the history

  3. Update 'final-newline' rule tests. 

    Split into smaller test-cases, use EditorConfigTestRule.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
    @Tapchicoma
    Tapchicoma committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    9ba5651 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into 701/initial-editorconfig-integration 

    Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
    @Tapchicoma
    Tapchicoma committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    13b9870 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Fix codestyle issues in FinalNewlineRuleTest. 

    Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
    @Tapchicoma
    Tapchicoma committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    507ed61 View commit details
    Browse the repository at this point in the history

  2. Align editorconfig names. 

    Make it follow common pattern '*EditorConfig*'.

Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
    @Tapchicoma
    Tapchicoma committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    30cfe18 View commit details
    Browse the repository at this point in the history