Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save To MKV #138

Closed
wants to merge 8 commits into from
Closed

Save To MKV #138

wants to merge 8 commits into from

Conversation

zjzhang-cn
Copy link
Member

@zjzhang-cn zjzhang-cn commented Aug 21, 2023

Description

save-to-mkv

Example save-to-mkv shows how to receive opus audio and h264 video using Pion and then save to mkv container

@@ -0,0 +1,5 @@
---
name: save-to-webm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still save-to-webm

save-to-mkv/main.go Outdated Show resolved Hide resolved
Co-authored-by: Atsushi Watanabe <atsushi.w@ieee.org>
@zjzhang-cn zjzhang-cn requested a review from at-wat August 22, 2023 04:55
@at-wat
Copy link
Member

at-wat commented Aug 28, 2023

@zjzhang-cn I've fixed the broken CI on master branch. Please rebase this

@at-wat
Copy link
Member

at-wat commented Aug 31, 2023

Seems have multiple lint errors

@zjzhang-cn zjzhang-cn changed the title save-to-mkv Save To Mkv Aug 31, 2023
@zjzhang-cn zjzhang-cn changed the title Save To Mkv Save H264 To MKV Aug 31, 2023
@zjzhang-cn zjzhang-cn changed the title Save H264 To MKV Save To MKV Aug 31, 2023
Copy link
Member

@adwpc adwpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants