Aggressive nomination on binding response

Add aggressive nomination when nominateOnBindingSuccess
pion · Dec 29, 2022 · 283943e · 283943e
1 parent ea00dc7
commit 283943e
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/selection.go b/selection.go
@@ -230,8 +230,11 @@ func (s *controlledSelector) HandleSuccessResponse(m *stun.Message, local, remot
 	p.state = CandidatePairStateSucceeded
 	s.log.Tracef("Found valid candidate pair: %s", p)
 	if p.nominateOnBindingSuccess {
-		if selectedPair := s.agent.getSelectedPair(); selectedPair == nil {
+		if selectedPair := s.agent.getSelectedPair(); selectedPair == nil ||
+			(selectedPair != p && selectedPair.priority() <= p.priority()) {
 			s.agent.setSelectedPair(p)
+		} else if selectedPair != p {
+			s.log.Tracef("ignore nominate new pair %s, already nominated pair %s", p, selectedPair)
 		}
 	}
 }