Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return io.EOF from closed udpMuxedConn #692

Merged
merged 1 commit into from
May 1, 2024
Merged

Return io.EOF from closed udpMuxedConn #692

merged 1 commit into from
May 1, 2024

Conversation

paulwe
Copy link
Contributor

@paulwe paulwe commented May 1, 2024

write returns io.ErrClosedPipe but read returns io.EOF...

@paulwe paulwe requested review from davidzhao and boks1971 May 1, 2024 04:13
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.15%. Comparing base (edb6929) to head (68a02a4).

Files Patch % Lines
udp_muxed_conn.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   79.21%   79.15%   -0.06%     
==========================================
  Files          41       41              
  Lines        3733     3733              
==========================================
- Hits         2957     2955       -2     
- Misses        547      548       +1     
- Partials      229      230       +1     
Flag Coverage Δ
go 79.15% <50.00%> (-0.06%) ⬇️
wasm 22.16% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulwe paulwe merged commit ed41bbf into master May 1, 2024
14 of 15 checks passed
@paulwe paulwe deleted the io-eof branch May 1, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants