Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pessimistic String calls for low level logs #694

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

paulwe
Copy link
Contributor

@paulwe paulwe commented May 1, 2024

No description provided.

@paulwe paulwe requested review from davidzhao and boks1971 May 1, 2024 06:53
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.16%. Comparing base (78a9ef9) to head (6c8372c).

❗ Current head 6c8372c differs from pull request most recent head 85e4c9b. Consider uploading reports for the commit 85e4c9b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
- Coverage   79.22%   79.16%   -0.06%     
==========================================
  Files          41       41              
  Lines        3735     3734       -1     
==========================================
- Hits         2959     2956       -3     
- Misses        547      548       +1     
- Partials      229      230       +1     
Flag Coverage Δ
go 79.16% <100.00%> (-0.06%) ⬇️
wasm 22.16% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulwe paulwe merged commit b5f4ca0 into master May 1, 2024
13 checks passed
@paulwe paulwe deleted the log-string branch May 1, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants