Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Avoid allocation storing last active time" #698

Merged
merged 1 commit into from
May 26, 2024

Conversation

jech
Copy link
Contributor

@jech jech commented May 9, 2024

This reverts commit e1c2d85.

In that commit, active time was changed from time.Time to
Unix time in order to avoid allocations. Unfortunately, that
has the side effect of discarding the monotonic component of
time.Time, and therefore makes our code vulnerable to stepping
of the system clock.

Fixes #697

This reverts commit e1c2d85.

In that commit, active time was changed from time.Time to
Unix time in order to avoid allocations.  Unfortunately, that
has the side effect of discarding the monotonic component of
time.Time, and therefore makes our code vulnerable to stepping
of the system clock.
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2@da3175f). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2     #698   +/-   ##
=====================================
  Coverage      ?   79.55%           
=====================================
  Files         ?       42           
  Lines         ?     3581           
  Branches      ?        0           
=====================================
  Hits          ?     2849           
  Misses        ?      518           
  Partials      ?      214           
Flag Coverage Δ
go 79.55% <100.00%> (?)
wasm 22.82% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulwe paulwe merged commit d14ef4c into pion:v2 May 26, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants