Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize payload queue for write path #320

Draft
wants to merge 2 commits into
base: chunk-tracker
Choose a base branch
from
Draft

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Apr 1, 2024

Follow up to #319
This optimizes the payload Queue for the write path by doing sorted inserts to the tsns slice.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 80.76%. Comparing base (c04adbf) to head (278dfbb).

Files Patch % Lines
payload_queue.go 77.77% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           chunk-tracker     #320      +/-   ##
=================================================
+ Coverage          80.63%   80.76%   +0.13%     
=================================================
  Files                 50       50              
  Lines               4280     4211      -69     
=================================================
- Hits                3451     3401      -50     
+ Misses               682      663      -19     
  Partials             147      147              
Flag Coverage Δ
go 80.76% <78.94%> (+0.13%) ⬆️
wasm 67.22% <78.94%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant