Start pion/transport@v3 #266
Merged
+272
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the replay detector interface and implementations to support indicating whether the accepted packet resulted in an update of the latest sequence number. Note: this is not a breaking change as the accept() callback was previously returning zero values and is now returning one, which can be ignored if desired. It may cause linter failures in some consumers if using a strict policy. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Updates replaydetector unit tests to check for latest sequence number updates. Also removes some of the test fragmentation and corrects a few tests that were previously returning erroneous results. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Removes the named return values from replay detector implementations as they are not currently being used and could lead to erroneous assignment in the future. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support replaydetector API changes
Relates to #264