Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for stopped transceivers #2274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 43 additions & 0 deletions rtptransceiver_test.go
Expand Up @@ -132,3 +132,46 @@ func Test_RTPTransceiver_SetCodecPreferences_PayloadType(t *testing.T) {

closePairNow(t, offerPC, answerPC)
}

// Assert that a transceiver, onces stopped, is rejected in offers
func Test_RTPTransceiver_Stopped_Transceiver_Is_Rejected(t *testing.T) {
// This test is skipped for now because it fails
return
m := &MediaEngine{}
assert.NoError(t, m.RegisterDefaultCodecs())

offerPC, err := NewAPI(WithMediaEngine(m)).NewPeerConnection(Configuration{})
assert.NoError(t, err)

answerPC, err := NewAPI(WithMediaEngine(m)).NewPeerConnection(Configuration{})
assert.NoError(t, err)

offerTransceiver, err := offerPC.AddTransceiverFromKind(RTPCodecTypeVideo)
assert.NoError(t, err)

_, err = answerPC.AddTransceiverFromKind(RTPCodecTypeVideo)
assert.NoError(t, err)

offer, err := offerPC.CreateOffer(nil)
assert.NoError(t, err)

assert.NoError(t, offerPC.SetLocalDescription(offer))
assert.NoError(t, answerPC.SetRemoteDescription(offer))

answer, err := answerPC.CreateAnswer(nil)
assert.NoError(t, err)

assert.NoError(t, answerPC.SetLocalDescription(answer))
assert.NoError(t, offerPC.SetRemoteDescription(answer))

assert.NotEmpty(t, offerTransceiver.Mid(), "A transceiver should have been associated after applying an answer")
assert.NoError(t, offerTransceiver.Stop())

offer, err = offerPC.CreateOffer(nil)
assert.NoError(t, err)

mediaDesc := offer.parsed.MediaDescriptions[0]
assert.Equal(t, mediaDesc.MediaName.Port.Value, 0, "After stopping a transceiver it should be rejected in offers")

closePairNow(t, offerPC, answerPC)
}