Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICE UDPMuxSrflx option #2298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevindejong
Copy link

Description

Adds an UDPMuxSrflx option to the setting engine for ICE agent config.

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 77.34% // Head: 77.25% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (3c5b9fa) compared to base (4e85358).
Patch coverage: 11.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2298      +/-   ##
==========================================
- Coverage   77.34%   77.25%   -0.09%     
==========================================
  Files          87       87              
  Lines        9197     9206       +9     
==========================================
- Hits         7113     7112       -1     
- Misses       1651     1661      +10     
  Partials      433      433              
Flag Coverage Δ
go 79.01% <11.11%> (-0.10%) ⬇️
wasm 70.03% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
icemux.go 35.29% <0.00%> (-19.26%) ⬇️
settingengine.go 57.14% <0.00%> (-1.40%) ⬇️
icegatherer.go 79.56% <100.00%> (+0.07%) ⬆️
internal/mux/mux.go 84.78% <0.00%> (-4.35%) ⬇️
sctptransport.go 77.90% <0.00%> (+0.74%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stv0g stv0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please fix the CI by adjusting the commit message?

The CI linter requires that you have a body in the commit message separated by an empty line from the title.

Have a look at other commits in this repo for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants