Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding support to TrackLocalStaticSample #2746

Merged
merged 1 commit into from Apr 10, 2024

Conversation

alexpokotilo
Copy link

To add padding-only samples call GeneratePadding

Description

v4 version of #2745

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 77.83%. Comparing base (b2af663) to head (059a152).

Files Patch % Lines
track_local_static.go 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2746      +/-   ##
==========================================
- Coverage   77.85%   77.83%   -0.02%     
==========================================
  Files          87       87              
  Lines        8190     8202      +12     
==========================================
+ Hits         6376     6384       +8     
- Misses       1343     1345       +2     
- Partials      471      473       +2     
Flag Coverage Δ
go 79.34% <66.66%> (-0.03%) ⬇️
wasm 64.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der
Copy link
Member

Sean-Der commented Apr 9, 2024

Fantastic LGTM @alexpokotilo

Can you add a E2E test that just shows sending padding (and getting it as expected) then it is good to merge :)

I will make sure to do /v3 also

To add padding-only samples call GeneratePadding
@alexpokotilo
Copy link
Author

alexpokotilo commented Apr 10, 2024

Fantastic LGTM @alexpokotilo

Can you add a E2E test that just shows sending padding (and getting it as expected) then it is good to merge :)

I will make sur\e to do /v3 also

You are right ! Added test. Please propagate this fix into v3

@Sean-Der
Copy link
Member

Anything you need on /v3 I will make sure to propagate @alexpokotilo !

@Sean-Der Sean-Der merged commit e60bf03 into pion:master Apr 10, 2024
16 of 17 checks passed
@alexpokotilo alexpokotilo deleted the static-sample-padding-support branch April 10, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants