Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add github action ci workflow #85

Merged
merged 2 commits into from Mar 27, 2023

Conversation

felipeplets
Copy link
Contributor

@felipeplets felipeplets commented Mar 12, 2023

Add GitHub Action CI workflow.

This workflow will run with a matrix strategy meaning that we will test with every mocha version the library supports according to the peerDependencies specified in the package.json and every supported NodeJS version according to the Release Schedule

The workflow will run:

  • when a commit is pushed to the master branch
  • and when a commit is pushed in a PR and it will block the PR from being merged in case the workflow fails.

@felipeplets
Copy link
Contributor Author

@piotrwitek reaching out to see if you can approve this workflow so that we can get it running and start looking into the other PRs.

@felipeplets
Copy link
Contributor Author

@piotrwitek if you are looking for someone to share the package maintenance let me know. And, feel free to invite me.
I maintain other packages and have quite some experience in NodeJS / npm.

@piotrwitek
Copy link
Owner

@piotrwitek if you are looking for someone to share the package maintenance let me know. And, feel free to invite me. I maintain other packages and have quite some experience in NodeJS / npm.

Thanks for your offer, I'm considering it, let me sort out the repo config for that. I'll let you know this week.

@piotrwitek piotrwitek merged commit 53909e0 into piotrwitek:master Mar 27, 2023
32 checks passed
@piotrwitek
Copy link
Owner

piotrwitek commented Mar 27, 2023

@felipeplets I would like to add you as a collaborator if you're still interested, please tell me what channel would you prefer for communication-related to maintenance. I like discord but I'm open to suggestions.

@felipeplets
Copy link
Contributor Author

@piotrwitek thank you. Discord works for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants