New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FunctionKeys and NonFunctionKeys does not filter undefined and null #148

Open

hubvue wants to merge 2 commits into piotrwitek:master from hubvue:master

hubvue commented Aug 7, 2020

Description

When I was using Functionkeys and NonFunctionKeys type, I found that undefined and null were not filtered out

Related issues:

Resolved #XXX

Checklist

I have read CONTRIBUTING.md
I have linked all related issues above
I have rebased my branch

For bugfixes:

I have added at least one unit test to confirm the bug have been fixed
I have checked and updated TOC and API Docs when necessary

For new features:

I have added entry in TOC and API Docs
I have added a short example in API Docs to demonstrate new usage
I have added type unit tests with dts-jest

hubvue added 2 commits

August 7, 2020 16:34


          fix: FunctionKeys and NonFunctionKeys does not filter undefined and null

62bfe33


          chore(mapped-types): fix NonFunctionKeys should be not need to filter…

ad439ac

… null type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment