Skip to content

Commit

Permalink
fix: Parameter overwritten does not work when resubmitting archived w…
Browse files Browse the repository at this point in the history
…orkflow (argoproj#11086) (argoproj#11087)

Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
  • Loading branch information
toyamagu-2021 authored and JPZ13 committed Jul 4, 2023
1 parent b00cbd8 commit 9fb9a26
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions server/workflowarchive/archived_workflow_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ func (w *archivedWorkflowServer) ResubmitArchivedWorkflow(ctx context.Context, r
return nil, sutils.ToStatusError(err, codes.Internal)
}

newWF, err := util.FormulateResubmitWorkflow(wf, req.Memoized, nil)
newWF, err := util.FormulateResubmitWorkflow(wf, req.Memoized, req.Parameters)
if err != nil {
return nil, sutils.ToStatusError(err, codes.Internal)
}
Expand All @@ -286,7 +286,7 @@ func (w *archivedWorkflowServer) RetryArchivedWorkflow(ctx context.Context, req
_, err = wfClient.ArgoprojV1alpha1().Workflows(req.Namespace).Get(ctx, wf.Name, metav1.GetOptions{})
if apierr.IsNotFound(err) {

wf, podsToDelete, err := util.FormulateRetryWorkflow(ctx, wf, req.RestartSuccessful, req.NodeFieldSelector, nil)
wf, podsToDelete, err := util.FormulateRetryWorkflow(ctx, wf, req.RestartSuccessful, req.NodeFieldSelector, req.Parameters)
if err != nil {
return nil, sutils.ToStatusError(err, codes.Internal)
}
Expand Down

0 comments on commit 9fb9a26

Please sign in to comment.