Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate to EventEmitterAsyncResource from core #433

Merged
merged 3 commits into from
Oct 30, 2023
Merged

fix: migrate to EventEmitterAsyncResource from core #433

merged 3 commits into from
Oct 30, 2023

Conversation

groozin
Copy link
Contributor

@groozin groozin commented Oct 23, 2023 •
edited

Fixes: #426

  • Updated the types definitions to include EventEmitterAsyncResource
  • Removed external package for EventEmitterAsyncResource
  • Updated typescript to v5 - needed for the type definitions
  • Fixed type errors after upgrade to ts v5

Note: I guess this loses the compatibility with node versions prior to inclusion of EventEmitterAsyncResource

@groozin groozin force-pushed the fix/migrate-to-core-EventEmitterAsyncResource branch from 17bc15d to c2fc550 Compare October 23, 2023 11:14
@groozin groozin marked this pull request as ready for review October 23, 2023 11:18
simoneb
simoneb approved these changes Oct 23, 2023
View reviewed changes
Copy link

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

metcoder95
metcoder95 reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but lint is failing; can you check?

I guess this loses the compatibility with node versions prior to inclusion of EventEmitterAsyncResource

That's fine, EventEmitterAsyncResource was added on v16, which is the minimum version we support 👍

src/worker.ts Show resolved Hide resolved
@garybernhardt garybernhardt mentioned this pull request Oct 23, 2023
Closed
@metcoder95
Copy link
Member

Thanks for the contribution!

@metcoder95 metcoder95 merged commit 0a539e2 into piscinajs:current Oct 30, 2023
10 checks passed
@ilteoood
Copy link

@metcoder95 may I ask you to create a new release for it?

@metcoder95
Copy link
Member

I'll reuse the current one 👍

metcoder95 pushed a commit that referenced this pull request Mar 10, 2024
@groozin @metcoder95
fix: migrate to EventEmitterAsyncResource from core (#433)
5c2264c
@AriPerkkio AriPerkkio mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metcoder95 metcoder95 metcoder95 approved these changes

@simoneb simoneb Awaiting requested review from simoneb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Piscina and @types/node > 20.8.0
4 participants
@groozin @metcoder95 @ilteoood @simoneb