Fixes for running demo.sh and pivio.sh via piping them into /bin/sh #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two issues:
1. The `read` after the "You seem like to run docker mac beta"
banner was effectively skipped.
2. The Gradle process did not exit after having built pivio-web
causing the setup scripts to hang indefinitely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting the demo with
curl https://raw.githubusercontent.com/pivio/pivio-boot/master/demo.sh | /bin/shas described at https://pivio.github.io still does not work out-of-the-box.
#7 failed to fix all issues.
There are still two issues:
readafter the "You seem like to run docker mac beta" banner is effectively skipped.pivio-webcausing the setup scripts to hang indefinitely.The changes in this merge request deal with both of these issues. See the comments there for more details.
(The described problems can only be observed if the respective script is piped to the shell. The script runs as intended if it is instead first saved locally and then run via e.g.
./demo.sh.)