-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve webpack logging #1394
Improve webpack logging #1394
Conversation
maxAssetSize: 5_120_000, | ||
// Silence warnings because the size includes the sourcemaps | ||
maxEntrypointSize: 15_120_000, | ||
maxAssetSize: 15_120_000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These always include the sourcemaps locally, so they end up being noise. Let's disable them again
@@ -30,6 +31,10 @@ const merge = mergeWithCustomize({ | |||
const tsconfig = JSON5.parse(fs.readFileSync("./tsconfig.json", "utf8")); | |||
|
|||
const shared = { | |||
stats: { | |||
preset: "errors-warnings", | |||
timings: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json
Outdated
@@ -216,6 +216,7 @@ | |||
"rollbar-sourcemap-webpack-plugin": "^3.3.0", | |||
"sass-loader": "^12.1.0", | |||
"selenium-webdriver": "^4.0.0-beta.4", | |||
"size-plugin": "2.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinned due to GoogleChromeLabs/size-plugin#40
@fregante IMO the "after" picture in the PR description is worse - it's longer and individual file sizes don't matter as much since we're an extension. For sizes, the things we care about are: 1) overall bundle size, 2) bundle size of content script, frame script, etc. to the extent they slow down loading
That screenshot looks good to me |
Yeah you may be right, especially due to the length.
Done.
|
This reverts commit d0ff2f6.
I find that webpack’s output is lengthy, noisy, and not particularly useful.
Before
After
I can exclude some files from the list too, for example the
nnn.bundle.js
filesCaveats