optimise destroy remove children

pixijs · May 1, 2024 · b4f363b · b4f363b
1 parent 1995851
commit b4f363b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/scene/container/Container.ts b/src/scene/container/Container.ts
@@ -1328,6 +1328,9 @@ export class Container<C extends ContainerChild = ContainerChild> extends EventE
         if (this.destroyed) return;
         this.destroyed = true;
 
+        // remove children is faster than removeChild..
+        const oldChildren = this.removeChildren(0, this.children.length);
+
         this.removeFromParent();
         this.parent = null;
         this._mask = null;
@@ -1344,8 +1347,6 @@ export class Container<C extends ContainerChild = ContainerChild> extends EventE
 
         const destroyChildren = typeof options === 'boolean' ? options : options?.children;
 
-        const oldChildren = this.removeChildren(0, this.children.length);
-
         if (destroyChildren)
         {
             for (let i = 0; i < oldChildren.length; ++i)