Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: accurate Max Texture check #10538

Merged
merged 3 commits into from
May 17, 2024
Merged

fix: accurate Max Texture check #10538

merged 3 commits into from
May 17, 2024

Conversation

GoodBoyDigital
Copy link
Member

@GoodBoyDigital GoodBoyDigital commented May 15, 2024 •
edited

Description of change

MAX_TEXTURES is now set by the GPU. WE do. alittle WebGL check to see how many textures it can support. This also happens for WebGPU. The reason we do a WebGL check is so that we don't need to create a promise and await the result. This keeps the code a lot simpler :D

Pre-Merge Checklist
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

fixes #10452
and possibly #10535

@korbit-ai Korbit AI
Copy link

korbit-ai bot commented May 15, 2024

My review is in progress 📖 - I will have feedback for you in a few minutes!

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 15, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

korbit-ai[bot]
korbit-ai bot reviewed May 15, 2024
View reviewed changes
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code and did not find any issues!

Please note that I can make mistakes, and you should still encourage your team to review your code as well.

@GoodBoyDigital GoodBoyDigital mentioned this pull request May 15, 2024
Closed
github-actions[bot]
github-actions bot reviewed May 17, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in this format:

chore: update Text docs
fix: text not rendering
feat: add new feature to Text
breaking: remove Text#resolution

@Zyie Zyie changed the title Do a more accurate Max Texture check fix: accurate Max Texture check May 17, 2024
@Zyie Zyie added ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8 labels May 17, 2024
@Zyie Zyie added this pull request to the merge queue May 17, 2024
Merged via the queue into dev with commit 175c458 May 17, 2024
5 of 6 checks passed
@Zyie Zyie deleted the chore/max-textures-fix branch May 17, 2024 12:06
@gabrielecirulli
Copy link

Please note this PR breaks worker support: #10546

@gabrielecirulli gabrielecirulli mentioned this pull request May 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@korbit-ai korbit-ai[bot] korbit-ai left review comments

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@Zyie Zyie Awaiting requested review from Zyie

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Pixi 8 - WebGL: INVALID_ENUM: activeTexture: texture unit out of range
4 participants
@GoodBoyDigital @gabrielecirulli @bigtimebuddy @Zyie