Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pr name checker #10542

Merged
merged 3 commits into from
May 17, 2024
Merged

chore: add pr name checker #10542

merged 3 commits into from
May 17, 2024

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented May 17, 2024

I've been consistently renaming pr's to follow the chore/fix/feat/breaking convention to make generating the release notes easier

This PR just adds a workflow to block a merge if the title isn't correct

This comment was marked as outdated.

korbit-ai[bot]

This comment was marked as duplicate.

Copy link

codesandbox-ci bot commented May 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit deafb13:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie changed the title chore: add pr name checker wrong: add pr name checker May 17, 2024
github-actions[bot]

This comment was marked as outdated.

@Zyie Zyie changed the title wrong: add pr name checker chore: add pr name checker May 17, 2024
@Zyie Zyie changed the title chore: add pr name checker wonrg: add pr name checker May 17, 2024
github-actions[bot]

This comment was marked as outdated.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in this format:

chore: update Text docs
fix: text not rendering
feat: add new feature to Text
breaking: remove Text#resolution 

@bigtimebuddy
Copy link
Member

Good idea.

Co-authored-by: Matt Karl <matt@mattkarl.com>
@Zyie Zyie changed the title wonrg: add pr name checker chore: add pr name checker May 17, 2024
github-actions[bot]

This comment was marked as outdated.

@Zyie Zyie added this pull request to the merge queue May 17, 2024
Merged via the queue into dev with commit 64c0cf5 May 17, 2024
5 of 6 checks passed
@Zyie Zyie deleted the chore/pr-name branch May 17, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants