Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C source and header files are not getting downloaded by go get #9

Closed
wants to merge 2 commits into from

Conversation

sithembiso
Copy link

@sithembiso sithembiso commented Dec 3, 2022

This was causing the following error (see go-git/go-git#624 for more details) when building a project that depends on this library:

# github.com/pjbgf/sha1cd/cgo
vendor/github.com/pjbgf/sha1cd/cgo/sha1.go:3:11: fatal error: 'lib/sha1.h' file not found
 #include <lib/sha1.h>
          ^~~~~~~~~~~~
1 error generated.

This was as a result of missing .c and .h files that go get omits. I have used the embed directive to include these files during the download.

@pjbgf
Copy link
Owner

pjbgf commented Dec 3, 2022

Thank you @sithembiso for your PR. I ended up merging #7 instead as that was submitted first and fixed the issue.

@sithembiso
Copy link
Author

@pjbgf No problem. I was going to withdraw this one anyway because it introduces a feature that is not available in older versions on Go.

@sithembiso sithembiso closed this Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants