Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Commit

Permalink
Remove errors.Print (#23)
Browse files Browse the repository at this point in the history
errors.Print had a number of problems. Firstly, it was hard coded to
print to os.Stderr, which made it difficult to test, and hard to write
an example test for. Secondly, comments made in issue #20 make it clear
that helpers need to have a high bar for inclusion in this package, and
something that wrapped errors.Fprint in a way that was hard to test
fails that bar.

So, Remove errors.Print, which frees the identifier for being reused
later, and reduces the size of the package.
  • Loading branch information
davecheney committed May 10, 2016
1 parent 502e17a commit 01fff4b
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ import (
"errors"
"fmt"
"io"
"os"
"runtime"
"strings"
)
Expand Down Expand Up @@ -202,7 +201,7 @@ func Cause(err error) error {
return err
}

// Print prints the error to Stderr.
// Fprint prints the error to the supplied writer.
// If the error implements the Causer interface described in Cause
// Print will recurse into the error's cause.
// If the error implements the inteface:
Expand All @@ -212,12 +211,6 @@ func Cause(err error) error {
// }
//
// Print will also print the file and line of the error.
func Print(err error) {
Fprint(os.Stderr, err)
}

// Fprint prints the error to the supplied writer.
// The format of the output is the same as Print.
// If err is nil, nothing is printed.
func Fprint(w io.Writer, err error) {
type location interface {
Expand Down

0 comments on commit 01fff4b

Please sign in to comment.