Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Switch to runtime.CallersFrames #183

Merged
merged 1 commit into from Jan 5, 2019
Merged

Conversation

davecheney
Copy link
Member

Fixes #160
Fixes #107

Signed-off-by: Dave Cheney dave@cheney.net

Fixes #160
Fixes #107

Signed-off-by: Dave Cheney <dave@cheney.net>
@davecheney davecheney added this to the 0.9 milestone Jan 5, 2019
@davecheney davecheney merged commit 4f47277 into master Jan 5, 2019
@davecheney davecheney deleted the runtime-callersframes branch January 5, 2019 08:23
@arcana261
Copy link

Hiiiiiiii

I wanted to provide a feed back guys! :)

I think since errors.Frame is exported type definition, it was not probably best to do this breaking change since probably lots of things depend on the fact that a Frame is a program counter. e.g. see this issue on evalphobia/logrus_sentry. I think if we wanted to provide a stable API and hide the fact of what Frame actually means, we had to wrap it inside a struct and make it un-exported :)

@davecheney
Copy link
Member Author

davecheney commented Jan 5, 2019 via email

@davecheney
Copy link
Member Author

@arcana261 see #188

arcana261 pushed a commit to arcana261/logrus_sentry that referenced this pull request Jan 9, 2019
A more recent [PR](pkg/errors#193) on pkg/errors
reverts usage of runtime.Frame after complaints about [breaking
change](pkg/errors#183).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants