This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Return errors.Frame to a uintptr #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates aws/aws-xray-sdk-go#77 Updates evalphobia/logrus_sentry#74 Go 1.12 has updated the behaviour of runtime.FuncForPC so that it behaves as it did in Go 1.11 and earlier. This allows errors.Frame to return to a uintptr representing the PC +1 of the caller. This will fix the build breakages of projects that were tracking HEAD of this package. Signed-off-by: Dave Cheney <dave@cheney.net>
arcana261
pushed a commit
to arcana261/logrus_sentry
that referenced
this pull request
Jan 9, 2019
A more recent [PR](pkg/errors#193) on pkg/errors reverts usage of runtime.Frame after complaints about [breaking change](pkg/errors#183).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates aws/aws-xray-sdk-go#77
Updates evalphobia/logrus_sentry#74
Go 1.12 has updated the behaviour of runtime.FuncForPC so that it
behaves as it did in Go 1.11 and earlier.
This allows errors.Frame to return to a uintptr representing the PC +1
of the caller. This will fix the build breakages of projects that were
tracking HEAD of this package.
Signed-off-by: Dave Cheney dave@cheney.net