Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

feat: support std errors functions #213

Merged
merged 13 commits into from Jan 3, 2020
Merged

feat: support std errors functions #213

merged 13 commits into from Jan 3, 2020

Commits on Nov 3, 2019

  1. feat: support std errors functions 

    add function `Is`, `As` and `Unwrap`, like std errors, so that we can
continue to use pkg/errors with go1.13 compatibility

Signed-off-by: Sherlock Holo <sherlockya@gmail.com>
    @Sherlock-Holo
    Sherlock-Holo committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    69e8329 View commit details
    Browse the repository at this point in the history

  2. style: delete useless comments 

    Signed-off-by: Sherlock Holo <sherlockya@gmail.com>
    @Sherlock-Holo
    Sherlock-Holo committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    5526281 View commit details
    Browse the repository at this point in the history

  3. build: update makefile 

    update makefile to download dependencies before test anything

Signed-off-by: Sherlock Holo <sherlockya@gmail.com>
    @Sherlock-Holo
    Sherlock-Holo committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    227a7b4 View commit details
    Browse the repository at this point in the history

  4. build: fix makefile 

    Signed-off-by: Sherlock Holo <sherlockya@gmail.com>
    @Sherlock-Holo
    Sherlock-Holo committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    9c503b9 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2019

  1. chore: delete useless comments 

    Signed-off-by: Sherlock Holo <sherlockya@gmail.com>
    @Sherlock-Holo
    Sherlock-Holo committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    34b42fb View commit details
    Browse the repository at this point in the history

  2. Restore Makefile

    @Sherlock-Holo
    Sherlock-Holo committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    057b7e2 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. revert: revert some change 

    some change are doing by PR pkg#206 and pkg#212 , so I don't need to do it

Signed-off-by: Sherlock Holo <sherlockya@gmail.com>
    @Sherlock-Holo
    Sherlock-Holo committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    d9389f6 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2019

  1. Merge remote-tracking branch 'pkg/master' into support-std-errors

    @Sherlock-Holo
    Sherlock-Holo committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    c93d5ce View commit details
    Browse the repository at this point in the history

  2. test: add more check for As unit test 

    Signed-off-by: Sherlock Holo <sherlockya@gmail.com>
    @Sherlock-Holo
    Sherlock-Holo committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    d0d34df View commit details
    Browse the repository at this point in the history

  3. revert: only support Is As Unwrap for >=go1.13 

    Signed-off-by: Sherlock Holo <sherlockya@gmail.com>
    @Sherlock-Holo
    Sherlock-Holo committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    487ff7b View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2019

  1. feat(Unwrap): allow <go1.13 can use Unwrap 

    `Unwrap` just use type assert, it doesn't need go1.13 actually

Signed-off-by: Sherlock Holo <sherlockya@gmail.com>
    @Sherlock-Holo
    Sherlock-Holo committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    e473c5d View commit details
    Browse the repository at this point in the history

  2. test: add go1.13 errors compatibility check 

    Signed-off-by: Sherlock Holo <sherlockya@gmail.com>
    @Sherlock-Holo
    Sherlock-Holo committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    bd678d4 View commit details
    Browse the repository at this point in the history

  3. refactor(Unwrap): don't allow <go1.13 use Unwrap 

    If we implement Unwrap ourselves, may create a risk of incompatibility
if Go 1.14 subtly changes its `Unwrap` implementation.
<go1.13 users doesn't have `Is` or `As`, if they want, they will use
xerrors and it also provides `Unwrap`

Signed-off-by: Sherlock Holo <sherlockya@gmail.com>
    @Sherlock-Holo
    Sherlock-Holo committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    613b81c View commit details
    Browse the repository at this point in the history