Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter: our linter is missing some rules from the Node.js codebase #90

Open
bcoe opened this issue Apr 9, 2022 · 3 comments
Open

linter: our linter is missing some rules from the Node.js codebase #90

bcoe opened this issue Apr 9, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@bcoe
Copy link
Collaborator

bcoe commented Apr 9, 2022

  • requirement of using errors.js, vs., new Error.
  • expectation of object vs., array destructuring.

Refs: #89

@bcoe bcoe added the enhancement New feature or request label Apr 9, 2022
@shadowspawn
Copy link
Collaborator

Our current dependency is:

    "eslint-plugin-node-core": "iansu/eslint-plugin-node-core",

@shadowspawn
Copy link
Collaborator

#17 was closed when @iansu found https://github.com/nodejs/eslint-plugin-nodejs-internal had been created.

(node-core-test is looking at using same linter and rules too: nodejs/node-core-test#22 )

@iansu
Copy link
Collaborator

iansu commented Jul 11, 2022

As far as I know nodejs/eslint-plugin-nodejs-internal is an exact copy of iansu/eslint-plugin-node-core. I just double checked and that repo still only has the one original commit. I can look at making a PR to update the nodejs version with whatever is in core (if there are changes) and then make a PR switching parseargs over to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants